Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[storage] port windows file time ticks bug fix from storage/stable #26535

Closed
wants to merge 1 commit into from
Closed

[storage] port windows file time ticks bug fix from storage/stable #26535

wants to merge 1 commit into from

Conversation

jeremymeng
Copy link
Member

@jeremymeng jeremymeng requested a review from xirzec July 18, 2023 22:40
@github-actions github-actions bot added the Storage Storage Service (Queues, Blobs, Files) label Jul 18, 2023
@jeremymeng jeremymeng mentioned this pull request Jul 17, 2023
Closed
18 tasks
@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

@jeremymeng jeremymeng changed the title [storage] port bug fix from storage/stable PR 25404 [storage] port windows file time ticks bug fix from storage/stable Jul 20, 2023
xirzec
xirzec requested changes Jul 20, 2023
View reviewed changes
Copy link
Member

@xirzec xirzec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here we have a collision between something that was fixed in main (66e595c) vs a lesser fix from the stable branch.

I believe the current behavior in main is the proper fix and this PR is not necessary.

@jeremymeng jeremymeng closed this Jul 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xirzec xirzec xirzec requested changes

@EmmaZhu EmmaZhu Awaiting requested review from EmmaZhu EmmaZhu is a code owner

@XiaoningLiu XiaoningLiu Awaiting requested review from XiaoningLiu XiaoningLiu is a code owner

@vinjiang vinjiang Awaiting requested review from vinjiang vinjiang is a code owner

@jiacfan jiacfan Awaiting requested review from jiacfan jiacfan is a code owner

@ljian3377 ljian3377 Awaiting requested review from ljian3377 ljian3377 is a code owner

Assignees
No one assigned
Labels
Storage Storage Service (Queues, Blobs, Files)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jeremymeng @azure-sdk @xirzec